Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate kubescheduler ComponentConfig v1beta2 #111547

Merged
merged 1 commit into from Aug 2, 2022
Merged

Deprecate kubescheduler ComponentConfig v1beta2 #111547

merged 1 commit into from Aug 2, 2022

Conversation

kerthcet
Copy link
Member

Signed-off-by: kerthcet kerthcet@gmail.com

What type of PR is this?

/kind cleanup
/sig scheduling

What this PR does / why we need it:

Maintaining three ComponentConfig versions simultaneously seems unnecessary, so we'd like to remove the v1beta2. But in v1.25, we'll mark it deprecated at first then remove it in v1.26 for smoothly migration.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Log line looks like:
W0730 00:37:46.130858 57861 configfile.go:73] KubeSchedulerConfiguration v1beta2 is deprecated in v1.25, will remove in v1.26

Does this PR introduce a user-facing change?

kube-scheduler ComponentConfig v1beta2 is deprecated in v1.25.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

- [KEP]: https://github.com/kubernetes/enhancements/issues/785

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jul 29, 2022
@k8s-ci-robot
Copy link
Contributor

@kerthcet: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jul 29, 2022
@kerthcet
Copy link
Member Author

/assign @alculquicondor

alculquicondor
alculquicondor reviewed Jul 29, 2022
View reviewed changes
cmd/kube-scheduler/app/options/configfile.go Outdated
@@ -67,6 +67,7 @@ func encodeConfig(cfg *config.KubeSchedulerConfiguration) (*bytes.Buffer, error)
var encoder runtime.Encoder
switch cfg.TypeMeta.APIVersion {
case configv1beta2.SchemeGroupVersion.String():
klog.Warning("KubeSchedulerConfiguration v1beta2 is deprecated in v1.25, will remove in v1.26")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

encodeConfig is not called if the log verbosity level is less than 2.

We should probably do this in loadConfig instead.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, updated.

@kerthcet kerthcet force-pushed the feat/mark-cc-v1beta2-deprecated branch from 1fcdcf2 to 920d6fb Compare August 1, 2022 03:56
@kerthcet kerthcet mentioned this pull request Aug 1, 2022
Closed
@kerthcet
Copy link
Member Author

kerthcet commented Aug 1, 2022

PTAL @alculquicondor

alculquicondor
alculquicondor reviewed Aug 2, 2022
View reviewed changes
cmd/kube-scheduler/app/options/configfile.go Outdated
@@ -51,6 +51,9 @@ func loadConfig(data []byte) (*config.KubeSchedulerConfiguration, error) {
// conversion. See KubeSchedulerConfiguration internal type definition for
// more details.
cfgObj.TypeMeta.APIVersion = gvk.GroupVersion().String()
if cfgObj.TypeMeta.APIVersion == configv1beta2.SchemeGroupVersion.String() {
klog.Warning("KubeSchedulerConfiguration v1beta2 is deprecated in v1.25, will remove in v1.26")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: "will be removed"

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alculquicondor, kerthcet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 2, 2022
@kerthcet
Deprecate kubescheduler ComponentConfig v1beta2
c8fbd78 
Signed-off-by: kerthcet <kerthcet@gmail.com>
@kerthcet kerthcet force-pushed the feat/mark-cc-v1beta2-deprecated branch from 920d6fb to c8fbd78 Compare August 2, 2022 14:11
@kerthcet
Copy link
Member Author

kerthcet commented Aug 2, 2022

Updated @alculquicondor

@alculquicondor
Copy link
Member

/lgtm
/priority important-soon

@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Aug 2, 2022
@k8s-ci-robot k8s-ci-robot merged commit 96439a0 into kubernetes:master Aug 2, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.25 milestone Aug 2, 2022
@kerthcet kerthcet deleted the feat/mark-cc-v1beta2-deprecated branch August 2, 2022 23:37
@alculquicondor
Copy link
Member

Can you remove it now before the code freeze?

@alculquicondor
Copy link
Member

nvm, we said 1.28 in #112257

@SataQiu SataQiu mentioned this pull request Apr 27, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alculquicondor alculquicondor alculquicondor left review comments

@chendave chendave Awaiting requested review from chendave

@sanposhiho sanposhiho Awaiting requested review from sanposhiho

Assignees

@alculquicondor alculquicondor

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.25
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kerthcet @k8s-ci-robot @alculquicondor