csi: add nodeExpandSecret support for CSI client & add unit test #105963
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
do-not-merge/work-in-progress
|
/test |
|
@zhucan: The
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/test pull-kubernetes-unit |
|
/remove-sig api-machinery |
k8s-ci-robot
removed
the
sig/api-machinery
k8s-ci-robot
added
sig/api-machinery
k8s-ci-robot
removed
the
needs-rebase
|
/test all |
zhucan
force-pushed
the
bugfix-95367
branch
2 times, most recently
from
c8e7e37
to
49bc3d7
Compare
zhucan
changed the title
Signed-off-by: zhucan <zhucan.k8s@gmail.com>
k8s-ci-robot
removed
lgtm
CSI spec 1.5 enhanced the spec to add optional secrets field to NodeExpandVolumeRequest. This commit adds NodeExpandSecret to the CSI PV source and also derive the expansion secret in csiclient to send it out as part of the nodeexpand request. Signed-off-by: Humble Chirammal <hchiramm@redhat.com> Signed-off-by: zhucan <zhucan.k8s@gmail.com>
Signed-off-by: zhucan <zhucan.k8s@gmail.com>
|
/test pull-kubernetes-unit |
1 similar comment
|
/test pull-kubernetes-unit |
|
/test pull-kubernetes-e2e-gce-storage-slow |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/milestone v1.25 |
humblec
added a commit
to humblec/kubernetes.github.io
that referenced
this pull request
Jul 25, 2022
Ref# KEP: kubernetes/enhancements#3173 Implementation: kubernetes/kubernetes#105963 Blog: kubernetes#32450 Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
humblec
added a commit
to humblec/kubernetes.github.io
that referenced
this pull request
Jul 25, 2022
Ref# KEP: kubernetes/enhancements#3173 Implementation: kubernetes/kubernetes#105963 Blog: kubernetes#32450 Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
humblec
added a commit
to humblec/kubernetes.github.io
that referenced
this pull request
Jul 25, 2022
Ref# KEP: kubernetes/enhancements#3173 Implementation: kubernetes/kubernetes#105963 Blog: kubernetes#33979 Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
humblec
added a commit
to humblec/kubernetes.github.io
that referenced
this pull request
Jul 25, 2022
Ref# KEP: kubernetes/enhancements#3173 Implementation: kubernetes/kubernetes#105963 Blog: kubernetes#33979 Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
humblec
added a commit
to humblec/kubernetes.github.io
that referenced
this pull request
Aug 1, 2022
Ref# KEP: kubernetes/enhancements#3173 Implementation: kubernetes/kubernetes#105963 Blog: kubernetes#33979 Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CSI spec 1.5 enhanced the spec to add optional secrets field to
NodeExpandVolumeRequest. This commit adds NodeExpandSecret to the
CSI PV source and also derive the expansion secret in csiclient to
send it out as part of the nodeexpand request.
What type of PR is this?
/kind feature
Optionally add one or more of the following kinds if applicable:
/kind api-change
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #95367
Special notes for your reviewer:
Does this PR introduce a user-facing change?
KEP reference：kubernetes/enhancements#3173