Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cleanup: Remove storageos volume plugins from k8s codebase #111620

Merged
merged 1 commit into from Aug 4, 2022
Merged

cleanup: Remove storageos volume plugins from k8s codebase #111620

merged 1 commit into from Aug 4, 2022

Conversation

Jiawei0227
Copy link
Contributor

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

This PR removes storageos storage plugin from k8s codebase.
The storageos plugin has been deprecated since v1.22
https://groups.google.com/g/kubernetes-sig-storage/c/IDIVmifA1FA

The code removal removes the dependency of storageos api and reduce
maintenance burden from storage perspective.

The storageos API, per k8s api policy, will not be removed. Whenever user tries to create PV using the inline storageos API, the following event will show in the pod:

Warning FailedMount 7m35s (x55 over 22m) kubelet, kubernetes-minion-group-kq16 Unable to attach or mount volumes: unmounted volumes=[mypvc], unattached volumes=[mypvc kube-api-access-22hdk[]: failed to get Plugin from volumeSpec for volume "mypvc" err=no volume plugin matched

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

action required: intree volume plugin storageos support is been completely removed from Kubernetes.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

/sig storage
/assign @msau42 @xing-yang @liggitt

@k8s-ci-robot k8s-ci-robot added the release-note-action-required Denotes a PR that introduces potentially breaking changes that require user action. label Aug 2, 2022
@k8s-ci-robot k8s-ci-robot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Aug 2, 2022
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. sig/storage Categorizes an issue or PR as relevant to SIG Storage. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/dependency Issues or PRs related to dependency changes area/kubelet sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/scalability Categorizes an issue or PR as relevant to SIG Scalability. labels Aug 2, 2022
@xing-yang
Copy link
Contributor

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Aug 2, 2022
@xing-yang
Copy link
Contributor

/milestone v1.25

@k8s-ci-robot k8s-ci-robot added this to the v1.25 milestone Aug 2, 2022
@xing-yang
Copy link
Contributor

As documented here, storageos plugin was deprecated in 1.22:
https://kubernetes.io/docs/concepts/storage/persistent-volumes/#types-of-persistent-volumes
We also mentioned that it is targeted for removal in 1.25 in the following blog:
https://kubernetes.io/blog/2021/12/10/storage-in-tree-to-csi-migration-status-update/#timeline-and-status

@msau42
Copy link
Member

msau42 commented Aug 2, 2022

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 2, 2022
@humblec
Copy link
Contributor

humblec commented Aug 2, 2022

@Jiawei0227 good to have release note section filled.

@Jiawei0227
Copy link
Contributor Author

/retest

@Jiawei0227
Copy link
Contributor Author

@Jiawei0227 good to have release note section filled.

I think I already did. Is there something else you are referring to? @humblec

@humblec
Copy link
Contributor

humblec commented Aug 2, 2022

@Jiawei0227 good to have release note section filled.

I think I already did. Is there something else you are referring to? @humblec

Oh.. release-note-action-required flag is still on and the PR description section for release note is not filled , isnt it ? or Am I missing something? @Jiawei0227

@Jiawei0227
Copy link
Contributor Author

@Jiawei0227 good to have release note section filled.

I think I already did. Is there something else you are referring to? @humblec

Oh.. release-note-action-required flag is still on and the PR description section for release note is not filled , isnt it ? or Am I missing something? @Jiawei0227

This actually means this PR might be a breaking change so it need special attention. The release notes have already been filled in the description section

@dims
Copy link
Member

dims commented Aug 2, 2022

/approve
/lgtm

@liggitt
Copy link
Member

liggitt commented Aug 2, 2022

/approve
for dep changes

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, Jiawei0227, liggitt, msau42

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 2, 2022
@xing-yang xing-yang mentioned this pull request Aug 2, 2022
Merged
@k8s-triage-robot
Copy link

The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass.

This bot retests PRs for certain kubernetes repos according to the following rules:

  • The PR does have any do-not-merge/* labels
  • The PR does not have the needs-ok-to-test label
  • The PR is mergeable (does not have a needs-rebase label)
  • The PR is approved (has cncf-cla: yes, lgtm, approved labels)
  • The PR is failing tests required for merge

You can:

/retest

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 2, 2022
@pacoxu pacoxu added this to Waiting on Author in SIG Node PR Triage Aug 3, 2022
@dims
Copy link
Member

dims commented Aug 3, 2022

NOTE for release team: Last minute conflict in the rush before the code freeze, this had all the approvals, so we will try to rebase this correctly and merge it hopefully in a day.

@Jiawei0227 can you please rebase? cc @xing-yang

@k8s-ci-robot k8s-ci-robot removed lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Aug 3, 2022
@Jiawei0227
Copy link
Contributor Author

NOTE for release team: Last minute conflict in the rush before the code freeze, this had all the approvals, so we will try to rebase this correctly and merge it hopefully in a day.

@Jiawei0227 can you please rebase? cc @xing-yang

Done

@Jiawei0227
Copy link
Contributor Author

/retest

@liggitt
Copy link
Member

liggitt commented Aug 3, 2022

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 3, 2022
@k8s-ci-robot k8s-ci-robot merged commit d4795e4 into kubernetes:master Aug 4, 2022
SIG Node PR Triage automation moved this from Waiting on Author to Done Aug 4, 2022
@xing-yang xing-yang mentioned this pull request Jan 12, 2023
Merged
@danwinship danwinship mentioned this pull request May 18, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dchen1107 dchen1107 Awaiting requested review from dchen1107

@liggitt liggitt Awaiting requested review from liggitt

Assignees

@dims dims

@liggitt liggitt

@xing-yang xing-yang

@msau42 msau42

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/dependency Issues or PRs related to dependency changes area/kubelet cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note-action-required Denotes a PR that introduces potentially breaking changes that require user action. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/scalability Categorizes an issue or PR as relevant to SIG Scalability. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Node PR Triage
Done
Milestone
v1.25
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@Jiawei0227 @xing-yang @msau42 @humblec @dims @liggitt @k8s-ci-robot @k8s-triage-robot