Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vendor: Bump cAdvisor to v0.45.0 #111647

Merged
merged 1 commit into from Aug 3, 2022
Merged

vendor: Bump cAdvisor to v0.45.0 #111647

merged 1 commit into from Aug 3, 2022

Conversation

bobbypage
Copy link
Member

Signed-off-by: David Porter david@porter.me

What type of PR is this?

/kind feature

What this PR does / why we need it:

This updates to the latest version of cAdvisor.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

cAdvisor diff - google/cadvisor@v0.44.1...v0.45.0

This version includes the containerd API vendored directly into cAdvisor as part of containerd/containerd#7231 (google/cadvisor#3145 by @dims) to ensure that k/k is not vendoring an EoL version of containerd.

Note: containerd is still listed as dependency in go.mod because hcsshim requires it.

Does this PR introduce a user-facing change?

Update cAdvisor to v0.45.0

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

NONE

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Aug 2, 2022
@k8s-ci-robot
Copy link
Contributor

@bobbypage: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Aug 2, 2022
@bobbypage
Copy link
Member Author

/sig node
/assign @dims @liggitt

@k8s-ci-robot k8s-ci-robot added sig/node Categorizes an issue or PR as relevant to SIG Node. area/dependency Issues or PRs related to dependency changes and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Aug 2, 2022
@bobbypage bobbypage mentioned this pull request Aug 2, 2022
Closed
liggitt
liggitt reviewed Aug 2, 2022
View reviewed changes
go.mod Show resolved Hide resolved
go.mod Show resolved Hide resolved
@liggitt
Copy link
Member

liggitt commented Aug 2, 2022

/lgtm
/approve

 {
-	"directDependencies": 229,
+	"directDependencies": 228,
-	"transitiveDependencies": 261,
+	"transitiveDependencies": 262,
-	"totalDependencies": 322,
+	"totalDependencies": 323,
 	"maxDepthOfDependencies": 30
 }

as a follow-up, might be worth adding containerd/containerd to our unwanted-dependencies.json file, and seeing if there's a way to avoid the gogo/googleapis transitive dep

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 2, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bobbypage, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 2, 2022
@dims
Copy link
Member

dims commented Aug 2, 2022

/milestone v1.25

@k8s-ci-robot k8s-ci-robot added this to the v1.25 milestone Aug 2, 2022
@pacoxu pacoxu added this to Needs Approver in SIG Node PR Triage Aug 3, 2022
@k8s-triage-robot
Copy link

The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass.

This bot retests PRs for certain kubernetes repos according to the following rules:

  • The PR does have any do-not-merge/* labels
  • The PR does not have the needs-ok-to-test label
  • The PR is mergeable (does not have a needs-rebase label)
  • The PR is approved (has cncf-cla: yes, lgtm, approved labels)
  • The PR is failing tests required for merge

You can:

/retest

1 similar comment
@k8s-triage-robot
Copy link

The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass.

This bot retests PRs for certain kubernetes repos according to the following rules:

  • The PR does have any do-not-merge/* labels
  • The PR does not have the needs-ok-to-test label
  • The PR is mergeable (does not have a needs-rebase label)
  • The PR is approved (has cncf-cla: yes, lgtm, approved labels)
  • The PR is failing tests required for merge

You can:

/retest

@dims
Copy link
Member

dims commented Aug 3, 2022

@bobbypage looks like something changed underneath. please see the failure in pull-kubernetes-dependencies

NOTE for release team: This one had all the approvals to merge, but one of the things that merged before this one must have caused a dependency failure. @bobbypage will respin this and we will land it hopefully today.

@liggitt
Copy link
Member

liggitt commented Aug 3, 2022

looks like this needs a hack/update-vendor.sh to fix the presubmit

@k8s-triage-robot
Copy link

The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass.

This bot retests PRs for certain kubernetes repos according to the following rules:

  • The PR does have any do-not-merge/* labels
  • The PR does not have the needs-ok-to-test label
  • The PR is mergeable (does not have a needs-rebase label)
  • The PR is approved (has cncf-cla: yes, lgtm, approved labels)
  • The PR is failing tests required for merge

You can:

/retest

@bobbypage
vendor: Bump cAdvisor to v0.45.0
d9fda8a 
Signed-off-by: David Porter <david@porter.me>
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 3, 2022
@bobbypage
Copy link
Member Author

Done, rebased and updated the missing dependency

@liggitt
Copy link
Member

liggitt commented Aug 3, 2022

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 3, 2022
@k8s-ci-robot k8s-ci-robot merged commit d6a3a68 into kubernetes:master Aug 3, 2022
SIG Node PR Triage automation moved this from Needs Approver to Done Aug 3, 2022
@brandond
Copy link

brandond commented Nov 30, 2022 •
edited

Just wanted to cross-link google/cadvisor#3204 from this PR. It's causing us to have to fork cadvisor and revert the affected change as part of our v1.26.0 release.

@dims
Copy link
Member

dims commented Nov 30, 2022

@brandond thanks for the feedback, linking to the slack thread you started too https://kubernetes.slack.com/archives/C0BP8PW9G/p1669844347437479

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dims dims dims left review comments

@liggitt liggitt liggitt left review comments

@logicalhan logicalhan Awaiting requested review from logicalhan

@wojtek-t wojtek-t Awaiting requested review from wojtek-t

Assignees

@dims dims

@liggitt liggitt

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/dependency Issues or PRs related to dependency changes cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/node Categorizes an issue or PR as relevant to SIG Node. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
SIG Node PR Triage
Done
Milestone
v1.25
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@bobbypage @k8s-ci-robot @liggitt @dims @k8s-triage-robot @brandond