Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add warning log if volume calculation took too long than 1 second #107490

Merged
merged 1 commit into from Jul 29, 2022
Merged

add warning log if volume calculation took too long than 1 second #107490

merged 1 commit into from Jul 29, 2022

Conversation

pacoxu
Copy link
Member

@pacoxu pacoxu commented Jan 12, 2022

What type of PR is this?

/kind bug

What this PR does / why we need it:

See https://github.com/kubernetes/kubernetes/pull/107201/files#r782840954.

I think logging it seems to be much simpler than the metrics.

Log a warning message if the duration is more than 1 second. Is this better?

Kubelet check volumes every volumeStatsAggPeriod seconds(by default 2min).
For metrics, I prefer the latest duration Guage for each volume which is more than 100ms. (Most volume metrics can be retrieved in 10ms).

Which issue(s) this PR fixes:

Fixes #107201

Special notes for your reviewer:

Does this PR introduce a user-facing change?

kubelet: add log for volume metric collection taking too long

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/kubelet sig/node Categorizes an issue or PR as relevant to SIG Node. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jan 12, 2022
@pacoxu
Copy link
Member Author

pacoxu commented Jan 12, 2022

/sig storage
/cc @gnufied @dashpole

@k8s-ci-robot k8s-ci-robot added the sig/storage Categorizes an issue or PR as relevant to SIG Storage. label Jan 12, 2022
@pacoxu pacoxu mentioned this pull request Jan 12, 2022
Merged
1 task
@pacoxu pacoxu marked this pull request as draft January 12, 2022 10:35
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 12, 2022
@pacoxu pacoxu marked this pull request as ready for review January 12, 2022 10:43
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 12, 2022
yangjunmyfm192085
yangjunmyfm192085 reviewed Jan 14, 2022
View reviewed changes
Copy link
Contributor

@yangjunmyfm192085 yangjunmyfm192085 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/retest

@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. and removed cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 14, 2022
@dims
Copy link
Member

dims commented Jan 14, 2022

There is a cncf-cla:no label on this PR. Can you please see the bot comments above to fix the CLA? This PR cannot progress unless the bot is happy with the CLA situation

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 17, 2022
@pacoxu pacoxu requested a review from gnufied January 17, 2022 02:45
@pacoxu
Copy link
Member Author

pacoxu commented Mar 1, 2022

/priority important-longterm
/triage accepted
part of kubernetes/enhancements#1029 (some log enhancement for the feature)

@k8s-ci-robot k8s-ci-robot added priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Mar 1, 2022
@pacoxu

This comment was marked as duplicate.

Sign in to view
@pacoxu
Copy link
Member Author

pacoxu commented Mar 1, 2022

/easycla

@pacoxu pacoxu moved this from Triage to Needs Reviewer in SIG Node PR Triage Mar 1, 2022
@pacoxu pacoxu mentioned this pull request Mar 1, 2022
Open
21 tasks
@pacoxu
Copy link
Member Author

pacoxu commented May 7, 2022

/assign @mrunalp

@pacoxu pacoxu mentioned this pull request May 7, 2022
Merged
8 tasks
@pacoxu pacoxu mentioned this pull request Jun 23, 2022
Merged
7 tasks
@pacoxu pacoxu requested a review from aojea July 26, 2022 01:23
@pacoxu
Copy link
Member Author

pacoxu commented Jul 26, 2022 •
edited

ping @gnufied @dashpole @mrunalp would you take a look?

BTW, also #107329

@dashpole
Copy link
Contributor

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 26, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dashpole, mrunalp, pacoxu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 28, 2022
@k8s-ci-robot
Copy link
Contributor

@pacoxu: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kubernetes-e2e-gce-ubuntu-containerd e3745a1 link unknown /test pull-kubernetes-e2e-gce-ubuntu-containerd

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

yangjunmyfm192085
yangjunmyfm192085 reviewed Jul 29, 2022
View reviewed changes
Copy link
Contributor

@yangjunmyfm192085 yangjunmyfm192085 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/test pull-kubernetes-e2e-gce-ubuntu-containerd

@k8s-ci-robot k8s-ci-robot merged commit cc69f8f into kubernetes:master Jul 29, 2022
SIG Node PR Triage automation moved this from Needs Reviewer to Done Jul 29, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.25 milestone Jul 29, 2022
@pacoxu pacoxu mentioned this pull request Sep 21, 2022
Draft
11 tasks
@pacoxu pacoxu mentioned this pull request Feb 2, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yangjunmyfm192085 yangjunmyfm192085 yangjunmyfm192085 left review comments

@mrunalp mrunalp mrunalp approved these changes

@bobbypage bobbypage Awaiting requested review from bobbypage

@wzshiming wzshiming Awaiting requested review from wzshiming

@dashpole dashpole Awaiting requested review from dashpole

@gnufied gnufied Awaiting requested review from gnufied

@aojea aojea Awaiting requested review from aojea

Assignees

@mrunalp mrunalp

@dashpole dashpole

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubelet cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Node PR Triage
Done
Milestone
v1.25
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@pacoxu @k8s-ci-robot @dims @dashpole @gnufied @mrunalp @aojea @yangjunmyfm192085