Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graduate component config to stable in kube-scheduler #110534

Merged
merged 2 commits into from Jul 29, 2022

Conversation

kerthcet
Copy link
Member

@kerthcet kerthcet commented Jun 13, 2022

Signed-off-by: kerthcet kerthcet@gmail.com

What type of PR is this?

/kind feature
/sig scheduling

What this PR does / why we need it:

Kube-scheduler Conponent config graduated to Beta since v1.19, it's time to GA the api as planed.

Which issue(s) this PR fixes:

Ref: kubernetes/enhancements#785
kubernetes/enhancements#3315

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Kube-Scheduler ComponentConfig is graduated to GA, `kubescheduler.config.k8s.io/v1` is available now. 
Plugin `SelectorSpread` is removed in v1.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

- [KEP]: https://github.com/kubernetes/enhancements/issues/785

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. kind/feature Categorizes issue or PR as related to a new feature. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jun 13, 2022
@kerthcet
Copy link
Member Author

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. area/code-generation area/test kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Jun 13, 2022
@kerthcet
Copy link
Member Author

/retest

@kerthcet kerthcet marked this pull request as ready for review June 14, 2022 03:44
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 14, 2022
@k8s-ci-robot k8s-ci-robot requested a review from damemi June 14, 2022 03:44
@kerthcet
Copy link
Member Author

kerthcet commented Jun 14, 2022

Waiting for the PRR review first kubernetes/enhancements#3346
/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 14, 2022
@kerthcet
Copy link
Member Author

/hold cancel
As the PRR approved, this pr is read to review. cc @alculquicondor

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 14, 2022
@alculquicondor
Copy link
Member

I have some KEPs to review, so I'll leave this for after enhancements freeze.

@k8s-triage-robot
Copy link

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

@fedebongio
Copy link
Contributor

/assign @kubernetes/api-reviewers
/remove-sig api-machinery

@leilajal
Copy link
Contributor

/remove-sig api-machinery

@k8s-ci-robot k8s-ci-robot removed the sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. label Jul 26, 2022
@kerthcet
Copy link
Member Author

kindly ping @liggitt as close to the code freeze deadline.

Copy link
Member

@liggitt liggitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

API changes lgtm, so marking that as approved

/approve
for API changes

/hold for a few questions about defaults and testing, and a few nits
@alculquicondor can re-review follow-ups and lgtm

pkg/scheduler/apis/config/v1/defaults.go Outdated Show resolved Hide resolved
pkg/scheduler/apis/config/v1/defaults.go Outdated Show resolved Hide resolved
pkg/scheduler/apis/config/v1/defaults.go Outdated Show resolved Hide resolved
pkg/scheduler/apis/config/v1/defaults.go Outdated Show resolved Hide resolved
pkg/scheduler/apis/config/v1/defaults.go Outdated Show resolved Hide resolved
@@ -0,0 +1,251 @@
/*
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like there were no changes in effective default values from v1beta3 → v1. Once we release v1, the defaults for it are locked, so were there any TODOs or outstanding issues where a tweak to defaults was desired?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The last iteration was v1beta3, introduced in 1.23, which increased some plugin weights https://github.com/kubernetes/enhancements/tree/master/keps/sig-scheduling/785-scheduler-component-config-api#proposal

Are we sure this is enough?

@Huang-Wei @kerthcet @damemi @denkensk for thoughts. Holding the graduation to 1.26 is an option.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My question is if we want to change the plugins and weights(maybe we treat these two things differently) in the future, should we upgrade the CC again, like v1 -> v2alpha1? If so, being cautious is not a bad thing. Maybe we need some feedbacks like a survey.

If no, since I have not gotten any negative feedbacks from the community so far(maybe just missed). From the guides in Graduation Criteria, it seems ready to GA now.

Deprecation of legacy plugins.
Minimal changes in the last beta iteration of the API.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer not to start a v2 right when we just released v1 :)

I actually expect that most of the world is still running k8s 1.22 or older. Or even if running 1.23, some might still using v1beta2. Since there is no pressure to get this to GA, maybe it's not a bad idea to send a survey to sig-scheduling? The focus of the survey should be on whether user-influenced like pod topology spreading give strong signal compared to internal scores.

Unless people really feel strong about graduating to GA and leaving it up to providers to decide if they want to change the weights for their customers.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems we came to the consequence to graduate this to GA.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 27, 2022
@liggitt liggitt moved this from In progress to API review completed, 1.25 in API Reviews Jul 27, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alculquicondor, kerthcet, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 27, 2022
pkg/scheduler/apis/config/v1/defaults.go Outdated Show resolved Hide resolved
@@ -0,0 +1,251 @@
/*
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The last iteration was v1beta3, introduced in 1.23, which increased some plugin weights https://github.com/kubernetes/enhancements/tree/master/keps/sig-scheduling/785-scheduler-component-config-api#proposal

Are we sure this is enough?

@Huang-Wei @kerthcet @damemi @denkensk for thoughts. Holding the graduation to 1.26 is an option.

@k8s-ci-robot k8s-ci-robot added sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Jul 28, 2022
@kerthcet
Copy link
Member Author

/retest

@leilajal
Copy link
Contributor

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jul 28, 2022
Signed-off-by: kerthcet <kerthcet@gmail.com>
Signed-off-by: kerthcet <kerthcet@gmail.com>
@kerthcet
Copy link
Member Author

Squashed @alculquicondor

@alculquicondor
Copy link
Member

Thanks @kerthcet

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 29, 2022
@kerthcet
Copy link
Member Author

Still hold now.

@alculquicondor
Copy link
Member

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 29, 2022
@k8s-ci-robot k8s-ci-robot merged commit 442548a into kubernetes:master Jul 29, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.25 milestone Jul 29, 2022
@kerthcet kerthcet deleted the feat/ga-component-config branch July 29, 2022 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api-review Categorizes an issue or PR as actively needing an API review. approved Indicates a PR has been approved by an approver from all required OWNERS files. area/code-generation area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
Status: API review completed, 1.25
Development

Successfully merging this pull request may close these issues.

None yet

7 participants