Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[golang] Update to 1.19rc2 (from 1.18.3) #111254

Merged
merged 6 commits into from Jul 26, 2022
Merged

[golang] Update to 1.19rc2 (from 1.18.3) #111254

merged 6 commits into from Jul 26, 2022

Conversation

dims
Copy link
Member

@dims dims commented Jul 19, 2022 •
edited

Go 1.19 GA release is planned for the first week of August:
https://groups.google.com/g/golang-dev/c/4xsD_D5oflI/m/77Ofgt_EAAAJ?utm_medium=email&utm_source=footer

With this PR, we would update to go1.19 rc2 and when the GA is available, we would move to that.

Signed-off-by: Davanum Srinivas davanum@gmail.com

What type of PR is this?

/kind feature

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

For v1.25, Kubernetes will be using golang 1.19, In this PR we update to 1.19rc2 as GA is not yet available.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jul 19, 2022
@k8s-ci-robot
Copy link
Contributor

@dims: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-priority Indicates a PR lacks a `priority/foo` label and requires one. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. area/kubelet area/release-eng Issues or PRs related to the Release Engineering subproject area/test and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 19, 2022
@k8s-ci-robot k8s-ci-robot added kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jul 19, 2022
@leilajal
Copy link
Contributor

/remove-sig api-machinery

@k8s-ci-robot k8s-ci-robot removed the sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. label Jul 19, 2022
@leilajal
Copy link
Contributor

/remove-sig api-machinery

@k8s-ci-robot
Copy link
Contributor

@leilajal: Those labels are not set on the issue: sig/api-machinery

In response to this:

/remove-sig api-machinery

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@liggitt
Copy link
Member

liggitt commented Jul 19, 2022

huh... did 1.19 gofmt make all those comment changes?

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 26, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, klueska, liggitt, mrunalp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dims
Copy link
Member Author

dims commented Jul 26, 2022

/test pull-kubernetes-verify
/test pull-kubernetes-verify-go-canary

@liggitt
Copy link
Member

liggitt commented Jul 26, 2022 •
edited

pull-kubernetes-verify-go-canary passed

looks like all the failures in pull-kubernetes-verify were formatting ones which will resolve when we bump test-infra

@dims
Copy link
Member Author

dims commented Jul 26, 2022

@liggitt yep that landed in kubernetes/test-infra#26920 and i am retesting the 2 jobs after that.

@leilajal
Copy link
Contributor

/remove-sig api-machinery

@k8s-ci-robot k8s-ci-robot removed the sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. label Jul 26, 2022
@dims
Copy link
Member Author

dims commented Jul 26, 2022

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 26, 2022
@k8s-ci-robot k8s-ci-robot merged commit 3ffdfbe into kubernetes:master Jul 26, 2022
SIG Node CI/Test Board automation moved this from Archive-it to Done Jul 26, 2022
SIG Node PR Triage automation moved this from Triage to Done Jul 26, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.25 milestone Jul 26, 2022
@nikhita nikhita mentioned this pull request Jul 27, 2022
Closed
This was referenced Jul 27, 2022
Merged
Merged
@robscott robscott mentioned this pull request Jul 27, 2022
Merged
@lavalamp
Copy link
Member

This is causing an annoying gofmt change: https://github.com/kubernetes-sigs/structured-merge-diff/pull/220/files#diff-054f947623025b6f29ed3f11f2849794e09e83d9a31927598d4c1f059e7c4fe1

cc @alexzielenski @apelisse

@liggitt
Copy link
Member

liggitt commented Jul 29, 2022 •
edited

xref https://tip.golang.org/doc/go1.19#go-doc

As part of this change, gofmt now reformats doc comments to make their rendered meaning clearer.

I'd recommend committing the go1.19 version of the doc, which go1.18 gofmt will leave alone

@apelisse
Copy link
Member

Yeah, nested lists aren't supported in comments by gofmt which is unfortunate and clearly changes the meaning of some comments.

@alexzielenski
Copy link
Contributor

filed an issue with golang golang/go#54129

@lavalamp
Copy link
Member

There's an example at the very bottom here: https://tip.golang.org/doc/comment

I guess they will probably close the issue :(

@shu-mutou shu-mutou mentioned this pull request Aug 1, 2022
Merged
@liggitt liggitt mentioned this pull request Aug 2, 2022
Closed
@Jefftree Jefftree mentioned this pull request Aug 4, 2022
Closed
@lengrongfu lengrongfu mentioned this pull request Oct 9, 2022
Closed
@nckturner nckturner mentioned this pull request Nov 7, 2022
Merged
This was referenced Nov 16, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liggitt liggitt liggitt left review comments

@mrunalp mrunalp mrunalp approved these changes

@lavalamp lavalamp Awaiting requested review from lavalamp

Assignees

@liggitt liggitt

@thockin thockin

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver area/cloudprovider area/code-generation area/conformance Issues or PRs related to kubernetes conformance tests area/e2e-test-framework Issues or PRs related to refactoring the kubernetes e2e test framework area/ipvs area/kubeadm area/kubectl area/kubelet area/network-policy Issues or PRs related to Network Policy subproject area/release-eng Issues or PRs related to the Release Engineering subproject area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/autoscaling Categorizes an issue or PR as relevant to SIG Autoscaling. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. sig/storage Categorizes an issue or PR as relevant to SIG Storage. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. wg/structured-logging Categorizes an issue or PR as relevant to WG Structured Logging.
Projects
SIG Node CI/Test Board
Done
SIG Node CI/Test Board
Archived in project
SIG Node PR Triage
Done
Milestone
v1.25
Development

Successfully merging this pull request may close these issues.

None yet