kubeadm: pass etcd progress notification flag to etcd #111383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note
|
/assign @neolit123 @aojea |
k8s-ci-robot
added
area/kubeadm
sig/cluster-lifecycle
neolit123
reviewed
Jul 25, 2022
k8s-ci-robot
added
triage/accepted
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: neolit123, p0lyn0mial The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/release-note-edit |
2 tasks
The experimental-watch-progress-notify-interval flag specifies an interval at which etcd sends data to the kube-api server. It is used by the WatchBookmark feature which is GA since 1.17. It will be used by a new WatchList feature which is Alpha since 1.25 In addition to that the feature was graduated to GA (non-experiment) in etcd 3.5 without any code changes
p0lyn0mial
force-pushed
the
kubeadm-etcd-progress-notificaiton
branch
from
caf7201
to
81dec8b
Compare
I did, plus |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
awesome 👏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
The experimental-watch-progress-notify-interval flag specifies an interval
at which etcd sends data to the kube-api server.
It is used by the WatchBookmark feature which is GA since 1.17.
It will be used by a new WatchList feature which is Alpha since 1.25
In addition to that the feature was graduated to GA (non-experiment) in etcd 3.5 without any code changes
Which issue(s) this PR fixes:
xref: kubernetes/kubeadm#2731
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: