Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kubeadm: add serializable health checks for etcd probes #110072

Merged
merged 1 commit into from May 30, 2022
Merged

kubeadm: add serializable health checks for etcd probes #110072

merged 1 commit into from May 30, 2022

Conversation

neolit123
Copy link
Member

@neolit123 neolit123 commented May 16, 2022 •
edited

What type of PR is this?

/kind feature

What this PR does / why we need it:

Use the etcd 3.5.3+ HTTP(s) endpoint "/health?serializable=true",
to allow the kubelet liveness and starup probes in the
kubeadm generated etcd.yaml (static Pod) to track
individual member health instead of tracking the whole
etcd cluster health.

Which issue(s) this PR fixes:

xref kubernetes/kubeadm#2567

Special notes for your reviewer:

NONE

Does this PR introduce a user-facing change?

kubeadm: modify the etcd static Pod liveness and readyness probes to use a new etcd 3.5.3+ HTTP(s) health check endpoint "/health?serializable=true" that allows to track the health of individual etcd members and not fail all members if a single member is not healthy in the etcd cluster.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels May 16, 2022
@neolit123 neolit123 mentioned this pull request May 16, 2022
Closed
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 16, 2022
@k8s-ci-robot k8s-ci-robot added area/kubeadm sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels May 16, 2022
@neolit123
Copy link
Member Author

/kind bug
given kubernetes/kubeadm#2567 was reported as such.

@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label May 16, 2022
@neolit123
Copy link
Member Author

/priority important-soon
/triage accepted

@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels May 16, 2022
@RA489
Copy link

RA489 commented May 16, 2022

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 16, 2022
@neolit123
Copy link
Member Author

/hold
this seems to be failing in local tests:
kubernetes/kubeadm#2567 (comment)

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 16, 2022
VirrageS
VirrageS suggested changes May 16, 2022
View reviewed changes
cmd/kubeadm/app/phases/etcd/local.go Outdated Show resolved Hide resolved
@neolit123
kubeadm: add serializable health checks for etcd probes
29148f6 
Use the etcd 3.5.3+ HTTP(s) endpoint "/health?serializable=true",
to allow the kubelet liveness and starup probes in the
kubeadm generated etcd.yaml (static Pod) to track
individual member health instead of tracking the whole
etcd cluster health.
@neolit123 neolit123 force-pushed the 1.25-kubeadm-etcd-liveness-probe branch from f939e1c to 29148f6 Compare May 16, 2022 17:20
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 16, 2022
@neolit123
Copy link
Member Author

/retest

@neolit123
Copy link
Member Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 16, 2022
pacoxu
pacoxu approved these changes May 30, 2022
View reviewed changes
Copy link
Member

@pacoxu pacoxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 30, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: neolit123, pacoxu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 92263ee into kubernetes:master May 30, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.25 milestone May 30, 2022
brandond added a commit to brandond/rke2 that referenced this pull request Jun 16, 2022
@brandond
Use serializable health checks for etcd probes
6390b75 
Refs:
* kubernetes/kubernetes#110072
* etcd-io/etcd#13399

Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
@brandond brandond mentioned this pull request Jun 16, 2022
Merged
brandond added a commit to brandond/rke2 that referenced this pull request Jun 16, 2022
@brandond
Use serializable health checks for etcd probes
d312a30 
Refs:
* kubernetes/kubernetes#110072
* etcd-io/etcd#13399

Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
brandond added a commit to brandond/rke2 that referenced this pull request Jun 16, 2022
@brandond
Use serializable health checks for etcd probes
f0e241c 
Refs:
* kubernetes/kubernetes#110072
* etcd-io/etcd#13399

Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
This was referenced Jun 16, 2022
Merged
Merged
Closed
brandond added a commit to rancher/rke2 that referenced this pull request Jun 16, 2022
@brandond
Use serializable health checks for etcd probes
d2854f0 
Refs:
* kubernetes/kubernetes#110072
* etcd-io/etcd#13399

Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
brandond added a commit to rancher/rke2 that referenced this pull request Jun 16, 2022
@brandond
Use serializable health checks for etcd probes
e075504 
Refs:
* kubernetes/kubernetes#110072
* etcd-io/etcd#13399

Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
brandond added a commit to rancher/rke2 that referenced this pull request Jun 16, 2022
@brandond
Use serializable health checks for etcd probes
6c8d170 
Refs:
* kubernetes/kubernetes#110072
* etcd-io/etcd#13399

Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
@bsctl bsctl mentioned this pull request Aug 9, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VirrageS VirrageS VirrageS requested changes

@pacoxu pacoxu pacoxu approved these changes

@fabriziopandini fabriziopandini Awaiting requested review from fabriziopandini

@RA489 RA489 Awaiting requested review from RA489

Assignees

@pacoxu pacoxu

@RA489 RA489

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubeadm cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.25
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@neolit123 @RA489 @k8s-ci-robot @pacoxu @VirrageS