New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ServerSideFieldValidation: Fix bug treating metadata fields as unknown fields #109268
Conversation
First commits are test-only changes, demonstrating the bug in #109215 - https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/109268/pull-kubernetes-integration/1510803616582078464
|
d4a7f74
to
eed9bb7
Compare
unclear if we want to pull this bugfix into 1.24 in addition to flipping the server-side validation feature back to alpha (deferring beta to 1.25 - xref #109215 (comment)) |
eed9bb7
to
954f3e7
Compare
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: liggitt The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
linked to failed integration run showing the expanded CRD test demonstrated the bug - https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/109268/pull-kubernetes-integration/1510803616582078464 |
and the passing integration run with the feature still enabled - https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/109268/pull-kubernetes-integration/1510812257360023552 |
6839d59
to
869d0b8
Compare
rebased on master with the feature disabled by default, integration run at https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/109268/pull-kubernetes-integration/1511038820122890240 |
/retest |
1 similar comment
/retest |
/triage accepted |
/lgtm |
What type of PR is this?
/kind bug
/area test
What this PR does / why we need it:
Fixes bug treating metadata fields as unknown fields in a custom resource whose CRD declared a metadata property
Which issue(s) this PR fixes:
fixes #109215
Special notes for your reviewer:
Does this PR introduce a user-facing change?
/assign @kevindelgado @apelisse