New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove deprecated metric and promote the replacement to STABLE #110310
remove deprecated metric and promote the replacement to STABLE #110310
Conversation
/sig api-machinery instrumentation |
/hold (I'm an approver so I want to ensure this gets vetted properly in reviews). |
9b34618
to
7313970
Compare
/assign @dgrisonnet |
This PR may require stable metrics review. Stable metrics are guaranteed to not change. Please review the documentation for the requirements and lifecycle of stable metrics and ensure that your metrics meet these guidelines. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since the deprecated metric and the alpha one replacing it have the same labels, I think it is fine to graduate the new metric to stable at the same time as removing the old one since users have been using this API for a while now without needing to extend it.
For what it's worth, I would have been against doing the two changes during the same release if the labels were different. That's because unless the metric is completely removed, you can't make sure that users transitioned to the new API and have experienced it.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dgrisonnet, logicalhan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/unhold |
It was actually already deprecated in a previous release. |
Yeah, I know, but even though the metric was deprecated, we were still exposing it. Maybe I am too cautious with things becoming |
This is actually not correct. After deprecation, metrics become auto-hidden, thereby triggering people to manually unhide it if they want to continue using the metric. |
/triage accepted |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
This PR removes the deprecated
apiserver_longrunning_gauge
metric and promotes its replacementapiserver_longrunning_requests
.Does this PR introduce a user-facing change?