Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix iSCSI over ipv6 #110688

Merged
merged 1 commit into from Aug 2, 2022
Merged

Fix iSCSI over ipv6 #110688

merged 1 commit into from Aug 2, 2022

Conversation

jsafrane
Copy link
Member

/kind bug

What this PR does / why we need it:

Addresses in the Kubernetes API objects (PV, Pod) have [] around IPv6 addresses, while addresses in /dev/ and /sys/ don't have them.

Add/remove [] as needed.

Which issue(s) this PR fixes:

Fixes #110687

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Fixed mounting of iSCSI volumes over IPv6 networks.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

cc @bswartz @rootfs for iSCSI knowledge. I tested it on Fedora and RHEL with a single PV, but I am not an iSCSI expert.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jun 21, 2022
@k8s-ci-robot k8s-ci-robot added sig/storage Categorizes an issue or PR as relevant to SIG Storage. approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jun 21, 2022
@jsafrane
Fix iSCSI over ipv6
2efe67e 
Addresses in the Kubernetes API objects (PV, Pod) have `[]` around IPv6
addresses, while addresses in /dev/ and /sys/ have addresses without them.

Add/remove `[]` as needed.
@xing-yang
Copy link
Contributor

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jul 24, 2022
@jsafrane
Copy link
Member Author

jsafrane commented Aug 2, 2022

/retest

@humblec
Copy link
Contributor

humblec commented Aug 2, 2022 •
edited

Thanks @jsafrane , lgtm .

[adding this info here for some reference] :
The present parser of portal is not solid , that said, there is a limitation as the logic of the parsing is based on : char atm . The IPv4 addresses survived with that model , but for ipv6 its not efficient, as it by default contains the char : in the address string. Either we have to have a solid parser which distinguish the address format ( ipv4 or ipv6) and then apply the logic of [] present or not, port string is appended or not....etc or have an interim one which just accommodate the part of this change like addressing [] which this PR brings.

more details https://kubernetes.slack.com/archives/C09QZFCE5/p1659444283160249

bswartz
bswartz approved these changes Aug 2, 2022
View reviewed changes
Copy link
Contributor

@bswartz bswartz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 2, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bswartz, jsafrane

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit c396744 into kubernetes:master Aug 2, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.25 milestone Aug 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aojea aojea aojea left review comments

@bswartz bswartz bswartz approved these changes

@chrishenzie chrishenzie Awaiting requested review from chrishenzie

@jingxu97 jingxu97 Awaiting requested review from jingxu97

Assignees

@bswartz bswartz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.25
Development

Successfully merging this pull request may close these issues.

iSCSI volumes don't work with ipv6
6 participants
@jsafrane @xing-yang @humblec @k8s-ci-robot @bswartz @aojea