Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix requests scope classification #110009

Merged
merged 1 commit into from May 12, 2022
Merged

Fix requests scope classification #110009

merged 1 commit into from May 12, 2022

Conversation

azylinski
Copy link
Contributor

@azylinski azylinski commented May 12, 2022 •
edited by wojtek-t

create (POST) custom resources should be scope:resource

What type of PR is this?

/kind bug

Which issue(s) this PR fixes:

Fixes #110001

Fix incorrectly report scope for request_duration_seconds and request_slo_duration_seconds metrics for POST custom resources API calls.

Special notes for your reviewer:

It's essentially a replication of:
https://github.com/kubernetes/kubernetes/blob/release-1.23/staging/src/k8s.io/apiserver/pkg/endpoints/installer.go#L640

Does this PR introduce a user-facing change?

Yes. After this change requests related metrics (like apiserver_request_duration_seconds) would have different scope label for "POST custom resource" type of requests

@azylinski
Fix requests scope classification
690c912 
create (POST) custom resources should be scope:resource
@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels May 12, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @azylinski. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/apiserver sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels May 12, 2022
@leilajal
Copy link
Contributor

/remove-sig api-machinery

@k8s-ci-robot k8s-ci-robot removed the sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. label May 12, 2022
wojtek-t
wojtek-t reviewed May 12, 2022
View reviewed changes
staging/src/k8s.io/apiserver/pkg/endpoints/metrics/metrics_test.go
`,
},
{
desc: "dry-run patch job status",
request: &http.Request{
Method: "PATCH",
URL: &url.URL{
RawPath: "/apis/batch/v1/namespaces/foo/pods/status",
RawPath: "/apis/batch/v1/namespaces/foo/jobs/bar/status",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:)

Thanks for fixing!

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels May 12, 2022
@wojtek-t
Copy link
Member

Added a release-note - we should backport that when the change merges.

/ok-to-test
/priority important-soon
/triage accepted

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels May 12, 2022
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 12, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: azylinski, wojtek-t

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 12, 2022
@k8s-ci-robot k8s-ci-robot merged commit 0e56766 into kubernetes:master May 12, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.25 milestone May 12, 2022
This was referenced May 17, 2022
Merged
Merged
Merged
Merged
k8s-ci-robot added a commit that referenced this pull request May 19, 2022
@k8s-ci-robot
Merge pull request #110087 from azylinski/automated-cherry-pick-of-#1…
93ae0ab 
…10009-upstream-release-1.24

Automated cherry pick of #110009: Fix requests scope classification
k8s-ci-robot added a commit that referenced this pull request May 19, 2022
@k8s-ci-robot
Merge pull request #110091 from azylinski/automated-cherry-pick-of-#1…
3ed06b7 
…10009-upstream-release-1.23

Automated cherry pick of #110009: Fix requests scope classification
k8s-ci-robot added a commit that referenced this pull request May 19, 2022
@k8s-ci-robot
Merge pull request #110092 from azylinski/automated-cherry-pick-of-#1…
93fbd78 
…10009-upstream-release-1.22

Automated cherry pick of #110009: Fix requests scope classification
k8s-ci-robot added a commit that referenced this pull request May 20, 2022
@k8s-ci-robot
Merge pull request #110093 from azylinski/automated-cherry-pick-of-#1…
a347c19 
…10009-upstream-release-1.21

Automated cherry pick of #110009: Fix requests scope classification
@azylinski azylinski mentioned this pull request Aug 2, 2022
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wojtek-t wojtek-t wojtek-t left review comments

@apelisse apelisse Awaiting requested review from apelisse

Assignees

@wojtek-t wojtek-t

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.25
Development

Successfully merging this pull request may close these issues.

POST requests to kube-apiserver for custom resources has incorrect scope classification
4 participants
@azylinski @k8s-ci-robot @leilajal @wojtek-t