New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add NodeInclusionPolicy to TopologySpreadConstraint in PodSpec #108492
Add NodeInclusionPolicy to TopologySpreadConstraint in PodSpec #108492
Conversation
/remove-sig api-machinery |
cfe9ee9
to
91f1a08
Compare
Rebased. |
kindly ping @liggitt |
we are in code freeze. Let's just wait. |
no changes to API bits, one nit on the doc on the feature gate. this still lgtm, will merge with the impl PR |
54b1941
to
320a97f
Compare
@kerthcet: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just nits
/approve
320a97f
to
751f439
Compare
Signed-off-by: kerthcet <kerthcet@gmail.com>
751f439
to
02f0a3e
Compare
cc @liggitt for approval |
/approve |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alculquicondor, Huang-Wei, kerthcet, liggitt The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: kerthcet kerthcet@gmail.com
What type of PR is this?
/kind feature
What this PR does / why we need it:
Part of kubernetes/enhancements#3094
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: