Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Print pod.Spec.RuntimeClassName in kubectl describe #110914

Merged
merged 4 commits into from Jul 20, 2022
Merged

Print pod.Spec.RuntimeClassName in kubectl describe #110914

merged 4 commits into from Jul 20, 2022

Conversation

yeahdongcn
Copy link

@yeahdongcn yeahdongcn commented Jul 1, 2022 •
edited

Signed-off-by: R0CKSTAR yeahdongcn@gmail.com

What type of PR is this?

/kind bug

What this PR does / why we need it:

In the NVIDIA GPU cluster, I explicitly specify RuntimeClassName in pod spec to nvidia to make certain pods can access the GPU resources, but I can't see the RuntimeClassName in kubectl describe pod.
It would be helpful if this field can be seen in kubectl describe.

Which issue(s) this PR fixes:

Fixes #

Print pod.Spec.RuntimeClassName if it is specified.

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Print pod.Spec.RuntimeClassName in kubectl describe

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@yeahdongcn
Print pod.Spec.RuntimeClassName in kubectl describe
ae31c04 
Signed-off-by: R0CKSTAR <yeahdongcn@gmail.com>
@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jul 1, 2022
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jul 1, 2022 •
edited

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: yeahdongcn / name: R0CKSTAR (ae31c04)

@k8s-ci-robot k8s-ci-robot added the do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Jul 1, 2022
@k8s-ci-robot
Copy link
Contributor

Welcome @yeahdongcn!

It looks like this is your first PR to kubernetes/kubernetes 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kubernetes has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

@yeahdongcn: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jul 1, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @yeahdongcn. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/kubectl sig/cli Categorizes an issue or PR as relevant to SIG CLI. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jul 1, 2022
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jul 1, 2022
ardaguclu
ardaguclu reviewed Jul 5, 2022
View reviewed changes
Copy link
Member

@ardaguclu ardaguclu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

/ok-to-test

staging/src/k8s.io/kubectl/pkg/describe/describe.go Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 5, 2022
@yeahdongcn
Resolve review comments
fa9f2c4 
Signed-off-by: R0CKSTAR <yeahdongcn@gmail.com>
@yeahdongcn yeahdongcn requested a review from ardaguclu July 6, 2022 06:25
@ardaguclu
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 6, 2022
brianpursley
brianpursley suggested changes Jul 11, 2022
View reviewed changes
Copy link
Member

@brianpursley brianpursley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a unit test

@yeahdongcn
Add unit test - TestDescribePodRuntimeClass
b8ecf6f 
Signed-off-by: R0CKSTAR <yeahdongcn@gmail.com>
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 12, 2022
@yeahdongcn
Copy link
Author

Can you add a unit test

Done.

❯ pwd
/Users/yexiaodong/go/src/github.com/yeahdongcn/kubernetes/staging/src/k8s.io/kubectl/pkg/describe
❯ go test
PASS
ok      k8s.io/kubectl/pkg/describe     0.336s

@yeahdongcn
Copy link
Author

/retest

brianpursley
brianpursley suggested changes Jul 12, 2022
View reviewed changes
Copy link
Member

@brianpursley brianpursley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the unit tests. Just a couple of small comments.

staging/src/k8s.io/kubectl/pkg/describe/describe_test.go Outdated Show resolved Hide resolved
staging/src/k8s.io/kubectl/pkg/describe/describe_test.go Outdated Show resolved Hide resolved
@yeahdongcn
Resolve review comments
d9294df 
Signed-off-by: R0CKSTAR <yeahdongcn@gmail.com>
brianpursley
brianpursley approved these changes Jul 20, 2022
View reviewed changes
Copy link
Member

@brianpursley brianpursley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 20, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brianpursley, yeahdongcn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 20, 2022
@k8s-triage-robot
Copy link

The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass.

This bot retests PRs for certain kubernetes repos according to the following rules:

  • The PR does have any do-not-merge/* labels
  • The PR does not have the needs-ok-to-test label
  • The PR is mergeable (does not have a needs-rebase label)
  • The PR is approved (has cncf-cla: yes, lgtm, approved labels)
  • The PR is failing tests required for merge

You can:

/retest

@k8s-ci-robot k8s-ci-robot merged commit bbd2f8f into kubernetes:master Jul 20, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.25 milestone Jul 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brianpursley brianpursley brianpursley approved these changes

@seans3 seans3 Awaiting requested review from seans3

@ardaguclu ardaguclu Awaiting requested review from ardaguclu

Assignees

@brianpursley brianpursley

@ardaguclu ardaguclu

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubectl cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cli Categorizes an issue or PR as relevant to SIG CLI. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.25
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@yeahdongcn @k8s-ci-robot @ardaguclu @k8s-triage-robot @brianpursley