Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include powershell in short description for kubectl completion #109773

Merged
merged 1 commit into from Jun 5, 2022
Merged

Include powershell in short description for kubectl completion #109773

merged 1 commit into from Jun 5, 2022

Conversation

danielhelfand
Copy link
Contributor

@danielhelfand danielhelfand commented May 4, 2022 •
edited

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Update short description for kubectl completion to include powershell as option.

Which issue(s) this PR fixes:

N/A

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Add missing powershell option to kubectl completion command short description

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

N/A

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels May 4, 2022
@k8s-ci-robot
Copy link
Contributor

@danielhelfand: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels May 4, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @danielhelfand. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@danielhelfand danielhelfand changed the title include powershell in short description for kubectl completion Include powershell in short description for kubectl completion May 4, 2022
@k8s-ci-robot k8s-ci-robot added area/kubectl sig/cli Categorizes an issue or PR as relevant to SIG CLI. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels May 4, 2022
@ardaguclu
Copy link
Member

I think this PR is introducing user-facing change. It'd be better to add this change into release notes?

1 similar comment
@ardaguclu
Copy link
Member

I think this PR is introducing user-facing change. It'd be better to add this change into release notes?

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels May 5, 2022
@danielhelfand
Copy link
Contributor Author

@ardaguclu Thanks for pointing this out. Wasn't sure how needed it was since it's a minor change, but I have gone ahead and added a small note.

marckhouzam
marckhouzam approved these changes May 10, 2022
View reviewed changes
Copy link
Member

@marckhouzam marckhouzam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this

@KnVerey
Copy link
Contributor

KnVerey commented May 10, 2022

/ok-to-test
/approve

Thanks!

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 10, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danielhelfand, KnVerey, marckhouzam

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 10, 2022
@danielhelfand
Copy link
Contributor Author

/test pull-kubernetes-conformance-kind-ga-only-parallel

@marckhouzam
Copy link
Member

I think this may be missing the lgtm label?

@ardaguclu
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 5, 2022
@k8s-ci-robot k8s-ci-robot merged commit 35940b7 into kubernetes:master Jun 5, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.25 milestone Jun 5, 2022
@ghost
Copy link

ghost commented Jun 5, 2022

How about having ash added for alpine linux?

@marckhouzam
Copy link
Member

How about having ash added for alpine linux?

The shell completion is provided by the spf13/cobra project which does not support ash. But I know nothing about the ash shell so it may turn out to be easy to add it to Cobra, I don't know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marckhouzam marckhouzam marckhouzam approved these changes

@dougsland dougsland Awaiting requested review from dougsland

@KnVerey KnVerey Awaiting requested review from KnVerey

Assignees

@ardaguclu ardaguclu

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubectl cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cli Categorizes an issue or PR as relevant to SIG CLI. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.25
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@danielhelfand @k8s-ci-robot @ardaguclu @KnVerey @marckhouzam