Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable 'running_managed_controllers' for KCM/CCM for cloud-node-lifecycle controller #111033

Merged
merged 1 commit into from Jul 21, 2022
Merged

Enable 'running_managed_controllers' for KCM/CCM for cloud-node-lifecycle controller #111033

merged 1 commit into from Jul 21, 2022

Conversation

jprzychodzen
Copy link
Contributor

@jprzychodzen jprzychodzen commented Jul 8, 2022 •
edited

What type of PR is this?

/kind feature

What this PR does / why we need it:

This PR enables running_managed_controllers for cloud node lifecycle running inside KCM and CCM.

This metric support HA migration described in KEP-2436

Which issue(s) this PR fixes:

It doesn't fix, but is a part of #111029

Special notes for your reviewer:

This is a first PR in a series. I plan to do similar PRs for other controllers that are related to KCM/CCM controllers migration.

Does this PR introduce a user-facing change?

Metric `running_managed_controllers` is enabled for Cloud Node Lifecycle controller

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

/sig cloud-provider

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jul 8, 2022
@k8s-ci-robot
Copy link
Contributor

@jprzychodzen: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jul 8, 2022
@k8s-ci-robot k8s-ci-robot added sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/network Categorizes an issue or PR as relevant to SIG Network. labels Jul 8, 2022
@leilajal
Copy link
Contributor

/remove-sig api-machinery

@k8s-ci-robot k8s-ci-robot removed the sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. label Jul 12, 2022
@jprzychodzen jprzychodzen changed the title Enable 'running_managed_controllers' for KCM/nodeIpamController Enable 'running_managed_controllers' for KCM/CCM for cloud-node-lifecycle controller Jul 20, 2022
@k8s-ci-robot k8s-ci-robot added area/cloudprovider sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. labels Jul 20, 2022
@jprzychodzen
Copy link
Contributor Author

/cc @cheftako @nckturner

@jprzychodzen
Copy link
Contributor Author

/retest

1 similar comment
@jprzychodzen
Copy link
Contributor Author

/retest

@leilajal
Copy link
Contributor

/remove-sig api-machinery

@k8s-ci-robot k8s-ci-robot removed the sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. label Jul 21, 2022
@cheftako
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 21, 2022
@dims
Copy link
Member

dims commented Jul 21, 2022

vendor/ changes looks good

/approve
/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cheftako, dims, jprzychodzen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 21, 2022
@k8s-ci-robot k8s-ci-robot merged commit 4995562 into kubernetes:master Jul 21, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.25 milestone Jul 21, 2022
This was referenced Jul 27, 2022
Merged
Merged
@jprzychodzen jprzychodzen mentioned this pull request Sep 2, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

@soltysh soltysh Awaiting requested review from soltysh

@cheftako cheftako Awaiting requested review from cheftako

@nckturner nckturner Awaiting requested review from nckturner

Assignees

@dims dims

@cheftako cheftako

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cloudprovider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/network Categorizes an issue or PR as relevant to SIG Network. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.25
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jprzychodzen @k8s-ci-robot @leilajal @cheftako @dims