Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[kube-up]: Bump coredns to v1.9.3 #110488

Merged
merged 1 commit into from Jun 9, 2022
Merged

[kube-up]: Bump coredns to v1.9.3 #110488

merged 1 commit into from Jun 9, 2022

Conversation

mzaian
Copy link
Contributor

@mzaian mzaian commented Jun 9, 2022

What type of PR is this?
/kind feature

What this PR does / why we need it:
Updates the coredns to v1.9.3 Also updates corefile migration to v1.0.17 tool to support coredns 1.9.3

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:
Does this PR introduce a user-facing change?:

kube-up now includes CoreDNS version v1.9.3

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jun 9, 2022
@k8s-ci-robot
Copy link
Contributor

@mzaian: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link
Contributor

Welcome @mzaian!

It looks like this is your first PR to kubernetes/kubernetes 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kubernetes has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Jun 9, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @mzaian. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/provider/gcp Issues or PRs related to gcp provider sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jun 9, 2022
@pacoxu
Copy link
Member

pacoxu commented Jun 9, 2022

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 9, 2022
@pacoxu pacoxu mentioned this pull request Jun 9, 2022
Merged
@pacoxu
Copy link
Member

pacoxu commented Jun 9, 2022

/lgtm
for kubeadm, I opened #110489.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 9, 2022
@pacoxu
Copy link
Member

pacoxu commented Jun 9, 2022 •
edited

/hold
as the image wait util registry.k8s.io/coredns/coredns:v1.9.3 is ready.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 9, 2022
mzaian added a commit to mzaian/k8s.io that referenced this pull request Jun 9, 2022
@mzaian
Add coredns image version of 1.9.3
c31045b 
This is needed for [#110488](kubernetes/kubernetes#110488). To have corends image v1.9.3.
@mzaian mzaian mentioned this pull request Jun 9, 2022
Merged
@mzaian
Copy link
Contributor Author

mzaian commented Jun 9, 2022

@pacoxu Created this PR to cover the image kubernetes/k8s.io#3821

@pacoxu
Copy link
Member

pacoxu commented Jun 9, 2022

/hold cancel
/retest

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 9, 2022
@pacoxu
Copy link
Member

pacoxu commented Jun 9, 2022

/assign dims mrhohn

@dims
Copy link
Member

dims commented Jun 9, 2022

/approve

cc @johnbelamaric

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, mzaian

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 9, 2022
@k8s-ci-robot k8s-ci-robot merged commit 7c127b3 into kubernetes:master Jun 9, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.25 milestone Jun 9, 2022
@mzaian mzaian mentioned this pull request Jun 9, 2022
Closed
9 tasks
seven4x
seven4x reviewed Jun 10, 2022
View reviewed changes
Copy link

@seven4x seven4x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

olemarkus pushed a commit to olemarkus/k8s.io that referenced this pull request Jun 26, 2022
@mzaian
Add coredns image version of 1.9.3
8ab3e90 
This is needed for [#110488](kubernetes/kubernetes#110488). To have corends image v1.9.3.
@floryut floryut mentioned this pull request Jul 28, 2022
Closed
@yankay yankay mentioned this pull request Nov 18, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seven4x seven4x seven4x left review comments

@bowei bowei Awaiting requested review from bowei

@mwielgus mwielgus Awaiting requested review from mwielgus

Assignees

@dims dims

@pacoxu pacoxu

@MrHohn MrHohn

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/gcp Issues or PRs related to gcp provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.25
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@mzaian @k8s-ci-robot @pacoxu @dims @seven4x @MrHohn