Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: set ProbeTerminationGracePeriod default to true #108541

Merged
merged 1 commit into from Jul 30, 2022
Merged

feat: set ProbeTerminationGracePeriod default to true #108541

merged 1 commit into from Jul 30, 2022

Conversation

kerthcet
Copy link
Member

@kerthcet kerthcet commented Mar 5, 2022 •
edited

Signed-off-by: kerthcet kerthcet@gmail.com

What type of PR is this?

/kind feature
/sig node

What this PR does / why we need it:

As mentioned on https://github.com/kubernetes/enhancements/tree/master/keps/sig-node/2238-liveness-probe-grace-period#beta-122

Which issue(s) this PR fixes:

Part of kubernetes/enhancements#2238

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Feature gate `ProbeTerminationGracePeriod` is enabled by default.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

- [KEP]: https://github.com/kubernetes/enhancements/issues/2238

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/feature Categorizes issue or PR as related to a new feature. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. sig/node Categorizes an issue or PR as relevant to SIG Node. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Mar 5, 2022
@kerthcet
Copy link
Member Author

kerthcet commented Mar 5, 2022

/retest

@kerthcet kerthcet marked this pull request as ready for review March 5, 2022 16:10
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 5, 2022
@kerthcet
Copy link
Member Author

kerthcet commented Mar 6, 2022

/retest

@kerthcet kerthcet force-pushed the feature/set-PreferNominatedNode-defaultvalue branch from ac90077 to 82a4e27 Compare March 7, 2022 10:29
@kerthcet
Copy link
Member Author

kerthcet commented Mar 7, 2022

/retest

@ehashman
Copy link
Member

We didn't target this KEP for 1.24 and we're well past the node soft freeze. I don't want to catch anyone by surprise in defaulting this on now. Should we wait for 1.25?

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 21, 2022
@ehashman ehashman moved this from Triage to Waiting on Author in SIG Node PR Triage Mar 24, 2022
@ehashman ehashman mentioned this pull request Apr 20, 2022
Open
12 tasks
ehashman
ehashman reviewed Apr 20, 2022
View reviewed changes
Copy link
Member

@ehashman ehashman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
/triage accepted
/priority important-soon
for 1.25

Will quickly update KEP metadata for 1.25 so this can be included. Leaving hold on until then.

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Apr 20, 2022
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 20, 2022
@kerthcet
Copy link
Member Author

Please update

kubernetes/pkg/features/kube_features.go

Lines 630 to 634 in 2b51b25

// owner: @ehashman
// alpha: v1.21
//
// Allows user to override pod-level terminationGracePeriod for probes
ProbeTerminationGracePeriod featuregate.Feature = "ProbeTerminationGracePeriod"

Also, this should have a release note.

Good catch, thanks.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Jun 16, 2022
@kerthcet
Copy link
Member Author

/retest

@marosset
Copy link
Contributor

Please update

kubernetes/pkg/features/kube_features.go

Lines 630 to 634 in 2b51b25

// owner: @ehashman
// alpha: v1.21
//
// Allows user to override pod-level terminationGracePeriod for probes
ProbeTerminationGracePeriod featuregate.Feature = "ProbeTerminationGracePeriod"

Also, this should have a release note.

Good catch, thanks.

Thanks!

@kerthcet
Copy link
Member Author

/retest

@kerthcet
Copy link
Member Author

since kubernetes/enhancements#3282 merged
/hold cancel

can you add the LGTM again @dchen1107

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 17, 2022
@pacoxu pacoxu moved this from Waiting on Author to Needs Approver in SIG Node PR Triage Jun 20, 2022
@mrunalp
Copy link
Contributor

mrunalp commented Jun 28, 2022

@psschwei ptal

@psschwei
Copy link
Contributor

Question: in the updated test plan for this KEP, we said we would add some unit and integration buckets. Do those need to be added before we flip the gate?

(for reference, #110733 adds the units, and I plan to get the integration ones in next week)

@kerthcet
Copy link
Member Author

cc @dchen1107 since we're close to the code freeze.

@kerthcet
Copy link
Member Author

cc @endocrimes @rphillips

@endocrimes
Copy link
Member

/lgtm
/hold

E2E coverage for this exists iirc (please confirm) so I don't have much in the way of test qualms with this progressing.

Lgtm with hold to let the unit coverage land first.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 29, 2022
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 29, 2022
@dchen1107 dchen1107 added this to the v1.25 milestone Jul 30, 2022
@dchen1107
Copy link
Member

Marked this for 1.25 milestone explicitly, but please point us to the e2e tests. Thanks!

@psschwei
Copy link
Contributor

links to e2e tests:

@mrunalp
Copy link
Contributor

mrunalp commented Jul 30, 2022

The unit tests PR has landed #110733. We can let this go in.

@mrunalp
Copy link
Contributor

mrunalp commented Jul 30, 2022

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 30, 2022
@k8s-ci-robot k8s-ci-robot merged commit 8594df1 into kubernetes:master Jul 30, 2022
SIG Node PR Triage automation moved this from Needs Approver to Done Jul 30, 2022
@kerthcet kerthcet deleted the feature/set-PreferNominatedNode-defaultvalue branch July 30, 2022 23:31
@psschwei psschwei mentioned this pull request Aug 1, 2022
Merged
@derekwaynecarr derekwaynecarr mentioned this pull request Jan 31, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liggitt liggitt liggitt left review comments

@ehashman ehashman ehashman left review comments

@aojea aojea aojea left review comments

@psschwei psschwei psschwei left review comments

@dchen1107 dchen1107 Awaiting requested review from dchen1107

@lavalamp lavalamp Awaiting requested review from lavalamp

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

Assignees

@endocrimes endocrimes

@ehashman ehashman

@dchen1107 dchen1107

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/node Categorizes an issue or PR as relevant to SIG Node. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Node PR Triage
Done
Milestone
v1.25
Development

Successfully merging this pull request may close these issues.

None yet
10 participants
@kerthcet @k8s-ci-robot @ehashman @dchen1107 @marosset @mrunalp @psschwei @endocrimes @liggitt @aojea