New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upgrade Azure/go-autorest/autorest to v0.11.27 #110371
upgrade Azure/go-autorest/autorest to v0.11.27 #110371
Conversation
/approve /assign @thockin @smarterclayton (need root OWNERS approval) |
35322f1
to
9cc9bb9
Compare
9cc9bb9
to
7ac9885
Compare
/test pull-kubernetes-e2e-kind-ipv6 |
/retest |
/approve (for root owner approval) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
vendor/github.com/Azure/go-autorest/autorest/adal/README.md says "This module will go out of support by March 31, 2023. For authenticating with Azure AD, use module azidentity instead"
What's the plan there?
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andyzhangx, dims, thockin The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @thockin, this is related to Credential provider extraction plan, once we use the standalone Credential provider out of k/k, we don't need this lib anymore. And btw, we don't upgrade this lib regularly unless we found some bugs, and this PR is for fixing one timeout setting issue. |
What type of PR is this?
/kind bug
What this PR does / why we need it:
upgrade Azure/go-autorest/autorest to v0.11.27
This PR has fix: Azure/go-autorest#669, also increases the timeout value from 0.5s to 2s which fixes the slow IMDS response issue in some cases.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
/kind bug
/priority important-soon
/sig cloud-provider
/area provider/azure
/triage accepted
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: