Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

apiserver: Remove the deprecated --service-account-api-audiences flag #108624

Merged
merged 1 commit into from Aug 2, 2022
Merged

apiserver: Remove the deprecated --service-account-api-audiences flag #108624

merged 1 commit into from Aug 2, 2022

Conversation

ialidzhikov
Copy link
Contributor

@ialidzhikov ialidzhikov commented Mar 10, 2022 •
edited by liggitt

/kind cleanup
/priority backlog

The deprecation happened in v1.13 with #70105.

Does this PR introduce a user-facing change?

action required: API server's deprecated `--service-account-api-audiences` flag is now removed.  Use `--api-audiences` instead.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@ialidzhikov
apiserver: Remove the deprecated --service-account-api-audiences flag
92707ca 
Signed-off-by: ialidzhikov <i.alidjikov@gmail.com>
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. priority/backlog Higher priority than priority/awaiting-more-evidence. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Mar 10, 2022
@k8s-ci-robot
Copy link
Contributor

@ialidzhikov: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Mar 10, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @ialidzhikov. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Mar 10, 2022
@ialidzhikov
Copy link
Contributor Author

/cc @mikedanese

@k8s-ci-robot k8s-ci-robot added area/apiserver sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Mar 10, 2022
@fedebongio
Copy link
Contributor

/remove-sig api-machinery
/sig auth
/cc @deads2k

@k8s-ci-robot k8s-ci-robot added sig/auth Categorizes an issue or PR as relevant to SIG Auth. and removed sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. labels Mar 10, 2022
@enj enj added this to Needs Triage in SIG Auth Old Mar 21, 2022
@enj enj moved this from Needs Triage to In Review in SIG Auth Old Mar 21, 2022
@enj
Copy link
Member

enj commented Mar 21, 2022

/assign @mikedanese

PTAL.

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 19, 2022
@ialidzhikov
Copy link
Contributor Author

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 19, 2022
@ialidzhikov
Copy link
Contributor Author

/cc @dims

@k8s-ci-robot k8s-ci-robot requested a review from dims June 19, 2022 17:10
@dims
Copy link
Member

dims commented Jul 31, 2022

@ialidzhikov is there more to this than just removing the command line parameter?

https://cs.k8s.io/?q=APIAudiences&i=nope&files=&excludeFiles=&repos=kubernetes/kubernetes

@ialidzhikov
Copy link
Contributor Author

The --api-audiences flag continues to be bound to the o.APIAudiences.

kubernetes/pkg/kubeapiserver/options/authentication.go

Lines 246 to 250 in 92707ca

fs.StringSliceVar(&o.APIAudiences, "api-audiences", o.APIAudiences, ""+
"Identifiers of the API. The service account token authenticator will validate that "+
"tokens used against the API are bound to at least one of these audiences. If the "+
"--service-account-issuer flag is configured and this flag is not, this field "+
"defaults to a single element list containing the issuer URL.")

See the PR description for more details. IMO it is safe to remove the --service-account-api-audiences flag - it was deprecated in v1.13 with #70105 in favor of --api-audiences.

@ialidzhikov
Copy link
Contributor Author

ialidzhikov commented Jul 31, 2022 •
edited

@mikedanese can you help checking this PR?

@dims
Copy link
Member

dims commented Jul 31, 2022

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 31, 2022
@dims dims added this to the v1.25 milestone Jul 31, 2022
@dims
Copy link
Member

dims commented Aug 2, 2022

/assign @liggitt

Notes: Simple PR to remove a command line parameter that was deprecated a while ago.

@liggitt
Copy link
Member

liggitt commented Aug 2, 2022

I found one usage using both, which seems unintentional (https://github.com/cert-manager/aws-privateca-issuer/blob/main/e2e/kind_config/config.yaml#L20-L21)... probably worth reporting an issue to them

/approve

@k8s-ci-robot k8s-ci-robot added release-note-action-required Denotes a PR that introduces potentially breaking changes that require user action. and removed release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Aug 2, 2022
@liggitt liggitt added the kind/deprecation Categorizes issue or PR as related to a feature/enhancement marked for deprecation. label Aug 2, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ialidzhikov, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 2, 2022
@liggitt
Copy link
Member

liggitt commented Aug 2, 2022

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 2, 2022
@k8s-ci-robot k8s-ci-robot merged commit 3051cb2 into kubernetes:master Aug 2, 2022
SIG Auth Old automation moved this from In Review to Closed / Done Aug 2, 2022
@rturner3 rturner3 mentioned this pull request Nov 3, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikedanese mikedanese Awaiting requested review from mikedanese

@cheftako cheftako Awaiting requested review from cheftako

@lavalamp lavalamp Awaiting requested review from lavalamp

@deads2k deads2k Awaiting requested review from deads2k

@dims dims Awaiting requested review from dims

Assignees

@liggitt liggitt

@mikedanese mikedanese

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/deprecation Categorizes issue or PR as related to a feature/enhancement marked for deprecation. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/backlog Higher priority than priority/awaiting-more-evidence. release-note-action-required Denotes a PR that introduces potentially breaking changes that require user action. sig/auth Categorizes an issue or PR as relevant to SIG Auth. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
SIG Auth
Archived in project
SIG Auth Old
Closed / Done
Milestone
v1.25
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@ialidzhikov @k8s-ci-robot @fedebongio @enj @k8s-triage-robot @dims @liggitt @mikedanese