Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable AcceleratorUsage Metrics: ga #110940

Merged
merged 1 commit into from Aug 1, 2022
Merged

Disable AcceleratorUsage Metrics: ga #110940

merged 1 commit into from Aug 1, 2022

Conversation

pacoxu
Copy link
Member

@pacoxu pacoxu commented Jul 4, 2022 •
edited

What type of PR is this?

/kind cleanup

kubernetes/enhancements#1867

What this PR does / why we need it:

DisableAcceleratorUsageMetrics is beta since 1.20.
It was planned to GA in v1.22. Sergey updated the feature to not use cadvisor status in #101712 since v1.22.

Now it is v1.25, it seems to be time to ga the feature gate.

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

The kubelet no longer supports collecting accelerator metrics through cAdvisor. The feature gate `DisableAcceleratorUsageMetrics` is now GA and cannot be disabled.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jul 4, 2022
@k8s-ci-robot k8s-ci-robot added area/kubelet sig/node Categorizes an issue or PR as relevant to SIG Node. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jul 4, 2022
@pacoxu
Copy link
Member Author

pacoxu commented Jul 4, 2022

/cc @SergeyKanzhelev @bobbypage @RenaudWasTaken

@pacoxu pacoxu force-pushed the ga-disable-accelerator branch 3 times, most recently from 75ba53a to 8d489bf Compare July 4, 2022 09:36
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 4, 2022
@pacoxu pacoxu added this to Triage in SIG Node PR Triage Jul 6, 2022
@pacoxu
Copy link
Member Author

pacoxu commented Jul 14, 2022

/test pull-kubernetes-e2e-gce-100-performance

@pacoxu
Copy link
Member Author

pacoxu commented Jul 14, 2022

/assign @SergeyKanzhelev
/triage accepted
/pirority important-longterm
or important-soon

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jul 14, 2022
@pacoxu pacoxu moved this from Triage to Needs Reviewer in SIG Node PR Triage Jul 14, 2022
@pacoxu
Copy link
Member Author

pacoxu commented Jul 20, 2022

/priority important-soon
if we want it ga in v1.25

@k8s-ci-robot k8s-ci-robot removed the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Jul 20, 2022
@bobbypage
Copy link
Member

@SergeyKanzhelev is OOO

LGTM from my side, I agree we should try to graduate this to GA in 1.25

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 20, 2022
@pacoxu pacoxu moved this from Needs Reviewer to Needs Approver in SIG Node PR Triage Jul 20, 2022
@pacoxu
Copy link
Member Author

pacoxu commented Jul 20, 2022

/assign @dchen1107 @derekwaynecarr

@dchen1107
Copy link
Member

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dchen1107, mrunalp, pacoxu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 29, 2022
@mrunalp mrunalp moved this from Needs Approver to Done in SIG Node PR Triage Jul 29, 2022
@dchen1107 dchen1107 added this to the v1.25 milestone Jul 30, 2022
@k8s-triage-robot
Copy link

The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass.

This bot retests PRs for certain kubernetes repos according to the following rules:

  • The PR does have any do-not-merge/* labels
  • The PR does not have the needs-ok-to-test label
  • The PR is mergeable (does not have a needs-rebase label)
  • The PR is approved (has cncf-cla: yes, lgtm, approved labels)
  • The PR is failing tests required for merge

You can:

/retest

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 30, 2022
@pacoxu
Copy link
Member Author

pacoxu commented Jul 30, 2022

Add back some removed imports that were used by new codes in master branch.

@kerthcet
Copy link
Member

kerthcet commented Aug 1, 2022

Basically approved by sig node approvers.
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 1, 2022
@pacoxu
Copy link
Member Author

pacoxu commented Aug 1, 2022

/retest

@k8s-ci-robot k8s-ci-robot merged commit dd54a04 into kubernetes:master Aug 1, 2022
@sftim
Copy link
Contributor

sftim commented Aug 1, 2022

How about this release note text:

The kubelet no longer supports collecting accelerator metrics through cAdvisor. The feature gate `DisableAcceleratorUsageMetrics` is now GA and cannot be disabled.

?

@pacoxu
Copy link
Member Author

pacoxu commented Aug 3, 2022

How about this release note text:

The kubelet no longer supports collecting accelerator metrics through cAdvisor. The feature gate `DisableAcceleratorUsageMetrics` is now GA and cannot be disabled.

edited
Thanks.

@pacoxu pacoxu mentioned this pull request Oct 14, 2022
Merged
@pacoxu pacoxu mentioned this pull request Dec 1, 2022
Closed
@bobbypage bobbypage mentioned this pull request Jan 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrunalp mrunalp mrunalp approved these changes

@dchen1107 dchen1107 Awaiting requested review from dchen1107

@yujuhong yujuhong Awaiting requested review from yujuhong

@bobbypage bobbypage Awaiting requested review from bobbypage

@RenaudWasTaken RenaudWasTaken Awaiting requested review from RenaudWasTaken

@SergeyKanzhelev SergeyKanzhelev Awaiting requested review from SergeyKanzhelev

Assignees

@bobbypage bobbypage

@derekwaynecarr derekwaynecarr

@dchen1107 dchen1107

@SergeyKanzhelev SergeyKanzhelev

@kerthcet kerthcet

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubelet cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/node Categorizes an issue or PR as relevant to SIG Node. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Node PR Triage
Done
Milestone
v1.25
Development

Successfully merging this pull request may close these issues.

None yet
10 participants
@pacoxu @bobbypage @dchen1107 @k8s-ci-robot @k8s-triage-robot @kerthcet @sftim @mrunalp @derekwaynecarr @SergeyKanzhelev