Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-1.24][GO]Update Go to 1.18.2 #110044

Merged
merged 1 commit into from May 14, 2022
Merged

[release-1.24][GO]Update Go to 1.18.2 #110044

merged 1 commit into from May 14, 2022

Conversation

cpanato
Copy link
Member

@cpanato cpanato commented May 13, 2022

What type of PR is this?

/kind feature
/area dependency

What this PR does / why we need it:

Update Go to 1.18.2

Which issue(s) this PR fixes:

xref kubernetes/release#2520

Does this PR introduce a user-facing change?

Kubernetes is now built with Golang 1.18.2

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

/assign @Verolop @saschagrunert @palnabarun @puerco @justaugustus @dims
cc @kubernetes/release-engineering

@cpanato
Update Go to 1.18.2
7970593 
Signed-off-by: cpanato <ctadeu@gmail.com>
@k8s-ci-robot k8s-ci-robot added this to the v1.24 milestone May 13, 2022
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. kind/feature Categorizes issue or PR as related to a new feature. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. area/dependency Issues or PRs related to dependency changes cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/release-eng Issues or PRs related to the Release Engineering subproject labels May 13, 2022
@k8s-ci-robot k8s-ci-robot added area/test sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels May 13, 2022
@cpanato cpanato mentioned this pull request May 13, 2022
Closed
19 tasks
@cpanato
Copy link
Member Author

cpanato commented May 13, 2022

/test pull-kubernetes-e2e-kind-ipv6

1 similar comment
@cpanato
Copy link
Member Author

cpanato commented May 14, 2022

/test pull-kubernetes-e2e-kind-ipv6

@dims
Copy link
Member

dims commented May 14, 2022

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 14, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, dims

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 14, 2022
@cpanato
Copy link
Member Author

cpanato commented May 14, 2022

/test pull-kubernetes-e2e-kind-ipv6

@puerco
Copy link
Member

puerco commented May 14, 2022

Thanks Carlos!
/lgtm

@puerco puerco added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label May 14, 2022
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label May 14, 2022
@cpanato
Copy link
Member Author

cpanato commented May 14, 2022

/triage accepted
/priority important-soon

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels May 14, 2022
@k8s-ci-robot k8s-ci-robot merged commit 49cd4f5 into kubernetes:release-1.24 May 14, 2022
@cpanato cpanato deleted the go118-rel124 branch May 14, 2022 13:18
@cpanato cpanato mentioned this pull request May 14, 2022
Merged
seanmalloy added a commit to KohlsTechnology/descheduler that referenced this pull request May 18, 2022
@seanmalloy
Bump To Go 1.18.2
e494a58 
The main k/k repo was updated to Go 1.18.2 for the
k8s v1.24.0 release. See below PR for reference.

kubernetes/kubernetes#110044
@seanmalloy seanmalloy mentioned this pull request May 18, 2022
Merged
damemi pushed a commit to damemi/descheduler that referenced this pull request May 23, 2022
@seanmalloy @damemi
Bump To Go 1.18.2
a25066f 
The main k/k repo was updated to Go 1.18.2 for the
k8s v1.24.0 release. See below PR for reference.

kubernetes/kubernetes#110044
@damemi damemi mentioned this pull request May 23, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeremyrickard jeremyrickard Awaiting requested review from jeremyrickard

@mkumatag mkumatag Awaiting requested review from mkumatag

Assignees

@dims dims

@puerco puerco

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/dependency Issues or PRs related to dependency changes area/release-eng Issues or PRs related to the Release Engineering subproject area/test cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.24
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@cpanato @dims @k8s-ci-robot @puerco