Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deprecate GlusterFS plugin from available in-tree drivers. #111485

Merged
merged 1 commit into from Aug 1, 2022
Merged

deprecate GlusterFS plugin from available in-tree drivers. #111485

merged 1 commit into from Aug 1, 2022

Conversation

humblec
Copy link
Contributor

@humblec humblec commented Jul 28, 2022 •
edited

GlusterFS is one of the first dynamic provisioner which made into
Kubernetes release v1.4.

#30888

When CSI plugins/drivers to start appear, glusterfs' CSI driver
came into existence, however this project is not maintianed at
present and the last release happened few years back.

https://github.com/gluster/gluster-csi-driver/releases/tag/v0.0.9

The possibilities of migration to compatible CSI driver was also
discussed #100897
and consensus was to start the deprecation in v1.25.

This commit start the deprecation proces of glusterfs plugin from
in-tree drivers.

Signed-off-by: Humble Chirammal hchiramm@redhat.com

/kind cleanup

-->

GlusterFS provisioner (`kubernetes.io/glusterfs`) has been deprecated in this release.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jul 28, 2022
@k8s-ci-robot k8s-ci-robot added sig/storage Categorizes an issue or PR as relevant to SIG Storage. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jul 28, 2022
@humblec
Copy link
Contributor Author

humblec commented Jul 28, 2022

/sig-storage

@humblec
Copy link
Contributor Author

humblec commented Jul 28, 2022

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jul 28, 2022
@humblec
Copy link
Contributor Author

humblec commented Jul 28, 2022

Cc @dims @xing-yang @msau42 @jsafrane @saad-ali

@humblec humblec mentioned this pull request Jul 28, 2022
Closed
@sftim
Copy link
Contributor

sftim commented Jul 28, 2022

For the (extended) changelog, could we also mention that the in-project CSI driver is available and hyperlink to that?

I'd also use backticks for the principal changelog:

-GlusterFS provisioner (kubernetes.io/glusterfs) has been deprecated in this release. 
+GlusterFS provisioner (`kubernetes.io/glusterfs`) has been deprecated in this release.

@humblec
Copy link
Contributor Author

humblec commented Jul 28, 2022

For the (extended) changelog, could we also mention that the in-project CSI driver is available and hyperlink to that?

Did you mean, the CSI driver in general or a specific one like glusterfs csi driver ? if latter is the case, unfortunatley no CSI driver exist as a follower to this

I'd also use backticks for the principal changelog:

-GlusterFS provisioner (kubernetes.io/glusterfs) has been deprecated in this release. 
+GlusterFS provisioner (`kubernetes.io/glusterfs`) has been deprecated in this release.

Accomodated the backticks in the release note

@sftim
Copy link
Contributor

sftim commented Jul 28, 2022

Ah, OK.

If feasible, it'd be great to mention this change in the deprecations blog article - see kubernetes/website#35426

@humblec
Copy link
Contributor Author

humblec commented Jul 28, 2022

Ah, OK.

If feasible, it'd be great to mention this change in the deprecations blog article - see kubernetes/website#35426

Sure.. can we ask the the existing PR to be refreshed with this info?

@sftim
Copy link
Contributor

sftim commented Jul 28, 2022

Sure.. can we ask the the existing PR to be refreshed with this info?

@humblec Best thing is if you comment on kubernetes/website#35426 or liaise directly with @katcosgrove to discuss the approach. Another person from SIG Storage could take a lead on that in your stead.

@humblec humblec mentioned this pull request Jul 28, 2022
Merged
@humblec
deprecate GlusterFS plugin from available in-tree drivers.
e675bfe 
GlusterFS is one of the first dynamic provisioner which made into
Kubernetes release v1.4.

kubernetes#30888

When CSI plugins/drivers to start appear, glusterfs' CSI driver
came into existence, however this project is not maintianed at
present and the last release happened few years back.

https://github.com/gluster/gluster-csi-driver/releases/tag/v0.0.9

The possibilities of migration to compatible CSI driver was also
discussed kubernetes#100897
and consensus was to start the deprecation in v1.25.

This commit start the deprecation process of glusterfs plugin from
in-tree drivers.

Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
@humblec humblec mentioned this pull request Jul 29, 2022
Closed
@dims
Copy link
Member

dims commented Jul 29, 2022

/approve

@dims
Copy link
Member

dims commented Jul 31, 2022

/assign @liggitt

Context : https://groups.google.com/g/kubernetes-sig-storage/c/iRwwuZRMWK4

@dims dims added this to the v1.25 milestone Jul 31, 2022
@liggitt
Copy link
Member

liggitt commented Aug 1, 2022

/lgtm
/approve

thanks!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 1, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, humblec, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 1, 2022
@k8s-ci-robot k8s-ci-robot merged commit 3dc5187 into kubernetes:master Aug 1, 2022
@msau42 msau42 mentioned this pull request Aug 2, 2022
Closed
2 tasks
@cici37 cici37 mentioned this pull request May 2, 2023
Merged
@msau42 msau42 mentioned this pull request May 2, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thockin thockin Awaiting requested review from thockin

@xing-yang xing-yang Awaiting requested review from xing-yang

Assignees

@liggitt liggitt

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.25
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@humblec @sftim @dims @liggitt @k8s-ci-robot