New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kubeadm: only taint CP nodes when the legacy "master" taint is present #109840
kubeadm: only taint CP nodes when the legacy "master" taint is present #109840
Conversation
During upgrade when a CP node is missing the old / legacy "master" taint, assume the user has manually removed it to allow workloads to schedule. In such cases do not re-taint the node with the new "control-plane" taint.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: neolit123 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
As this is only needed for upgrades from 1.23 to 1.24, this can be removed in v1.25 or later.
However, this logic has no side effects, so we can keep it.
Yep we can change the code later in 1.25 following the KEP plan. |
…09840-origin-release-1.24 Automated cherry pick of #109840: kubeadm: only taint CP nodes when the legacy "master" taint
What type of PR is this?
/kind bug
What this PR does / why we need it:
During upgrade when a CP node is missing the old / legacy "master"
taint, assume the user has manually removed it to allow
workloads to schedule.
In such cases do not re-taint the node with the new "control-plane"
taint.
Which issue(s) this PR fixes:
xref kubernetes/kubeadm#2200 (comment)
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: