Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[go] Bump images, dependencies and versions to go 1.19 #111679

Merged
merged 5 commits into from Aug 4, 2022
Merged

[go] Bump images, dependencies and versions to go 1.19 #111679

merged 5 commits into from Aug 4, 2022

Conversation

puerco
Copy link
Member

@puerco puerco commented Aug 4, 2022

What type of PR is this?

/kind feature
/area dependency

What this PR does / why we need it:

This PR updates go to version 1.19

Which issue(s) this PR fixes:

Part of kubernetes/release#2575

Special notes for your reviewer:

/cc @dims @cpanato @kubernetes/release-managers

Does this PR introduce a user-facing change?

Kubernetes is now built with go 1.19.0

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@puerco
Update kubecross version to v1.25.0-go1.19-bullseye.0
79df9e6 
Signed-off-by: Adolfo García Veytia (Puerco) <puerco@chainguard.dev>
@puerco
Bump test Makefile to final 1.19
5d2de18 
Signed-off-by: Adolfo García Veytia (Puerco) <puerco@chainguard.dev>
@puerco
Update default go to 1.19 in pubbot rules
2be8ac8 
Signed-off-by: Adolfo García Veytia (Puerco) <puerco@chainguard.dev>
@k8s-ci-robot k8s-ci-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Aug 4, 2022
@k8s-ci-robot k8s-ci-robot requested a review from a team August 4, 2022 03:11
@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. area/dependency Issues or PRs related to dependency changes cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/release-eng Issues or PRs related to the Release Engineering subproject area/test sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Aug 4, 2022
@puerco
Copy link
Member Author

puerco commented Aug 4, 2022 •
edited

/sig release
/priority critical-urgent
/assign @dims @cpanato @justaugustus

@k8s-ci-robot k8s-ci-robot added priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Aug 4, 2022
@puerco
Update versions and images to go 1.19 versions
7324b78 
Signed-off-by: Adolfo García Veytia (Puerco) <puerco@chainguard.dev>
@puerco
Update default go version in common.sh to 1.19
f17efe9 
Signed-off-by: Adolfo García Veytia (Puerco) <puerco@chainguard.dev>
@puerco puerco mentioned this pull request Aug 4, 2022
Closed
40 tasks
@puerco
Copy link
Member Author

puerco commented Aug 4, 2022

/test pull-kubernetes-e2e-gce-ubuntu-containerd

@aojea
Copy link
Member

aojea commented Aug 4, 2022

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 4, 2022
@ameukam
Copy link
Member

ameukam commented Aug 4, 2022

/lgtm

cpanato
cpanato approved these changes Aug 4, 2022
View reviewed changes
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!
/approve
/lgtm

@cpanato
Copy link
Member

cpanato commented Aug 4, 2022

please @dims review when you have some time, thanks!

@cpanato
Copy link
Member

cpanato commented Aug 4, 2022

/milestone v1.25

@k8s-ci-robot k8s-ci-robot added this to the v1.25 milestone Aug 4, 2022
@cpanato
Copy link
Member

cpanato commented Aug 4, 2022

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Aug 4, 2022
@dims
Copy link
Member

dims commented Aug 4, 2022

/approve
/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aojea, cpanato, dims, puerco, saschagrunert, xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 4, 2022
@palnabarun
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot merged commit 305ad47 into kubernetes:master Aug 4, 2022
@oomichi oomichi mentioned this pull request Dec 14, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saschagrunert saschagrunert saschagrunert approved these changes

@cpanato cpanato cpanato approved these changes

@xmudrii xmudrii xmudrii approved these changes

@dims dims Awaiting requested review from dims

Assignees

@dims dims

@justaugustus justaugustus

@ameukam ameukam

@cpanato cpanato

@aojea aojea

@palnabarun palnabarun

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/dependency Issues or PRs related to dependency changes area/release-eng Issues or PRs related to the Release Engineering subproject area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.25
Development

Successfully merging this pull request may close these issues.

None yet
10 participants
@puerco @aojea @ameukam @cpanato @dims @k8s-ci-robot @palnabarun @saschagrunert @xmudrii @justaugustus